Skip to content

fix: use tds row check instead of account (backport #4949) - #4988

Merged
ljain112 merged 2 commits into
version-16-hotfixfrom
mergify/bp/version-16-hotfix/pr-4949
Oct 8, 2026
Merged

fix: use tds row check instead of account (backport #4949)#4988
ljain112 merged 2 commits into
version-16-hotfixfrom
mergify/bp/version-16-hotfix/pr-4949

Conversation

@mergify

@mergify mergify Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Issue: In v16 we have already introduce checkbox for TDS row.

Accepted regression: Taxable value in PO and SO now includes TDS amounts. TDS account is not supposed to be used / not required / not useful in PO and SO

This is an automatic backport of pull request #4949 done by Mergify.

@ljain112 @mergify
fix: use tds row check instead of account
547dfa5 
(cherry picked from commit 326fe3d)

# Conflicts:
#	india_compliance/gst_india/overrides/transaction.py
@mergify mergify Bot added the conflicts label Oct 7, 2026
@mergify

mergify Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

Cherry-pick of 326fe3d has failed:

On branch mergify/bp/version-16-hotfix/pr-4949
Your branch is up to date with 'origin/version-16-hotfix'.

You are currently cherry-picking commit 326fe3d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   india_compliance/gst_india/overrides/test_transaction.py
	modified:   india_compliance/gst_india/report/gst_account_wise_summary/gst_account_wise_summary.py
	modified:   india_compliance/hooks.py
	modified:   india_compliance/income_tax_india/overrides/tax_withholding_category.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   india_compliance/gst_india/overrides/transaction.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@codacy-production

codacy-production Bot commented Oct 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric Results
Complexity 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@ljain112 ljain112 removed the conflicts label Oct 8, 2026
@ljain112
ljain112 merged commit fe8dd35 into version-16-hotfix Oct 8, 2026
15 checks passed
@ljain112
ljain112 deleted the mergify/bp/version-16-hotfix/pr-4949 branch October 8, 2026 06:06
@india-compliance-bot

india-compliance-bot commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 16.10.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ljain112 ljain112

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@india-compliance-bot @ljain112